feat: Add toggle for adding cross-sim to network name #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am roaming and if this is set to 2, then backup calling disappears completely (shows carrier name only) whereas 1 shows |
|
nvrmind, its correct |
fillwithjoy1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I read the code correctly, we can modify the CROSS_SIM_FORMAT to make it add "Cross SIM Calling" to the SIM card that has Cross SIM available.
This could be useful for showing the user that cross-sim is available. I don't have any SIM cards to test this at all, so this will rely on people that can test this out.I can confirm myself that setting KEY_CROSS_SIM_SPN_FORMAT_INT to 1 shows
[carrier name] Backup callingand setting it to 2 just shows the carrier nameCarrierConfigManager.java